feat: support revalidateTag with SWR behavior #3173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test latest and canary
📊 Package size report 0.06%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
feat/support-update-tag-and-revalidate-tag-second-arg
branch
5 times, most recently
from
5be6bef to
4da8739
Compare
pieh
changed the title
pieh
force-pushed
the
feat/support-update-tag-and-revalidate-tag-second-arg
branch
2 times, most recently
from
80e143c to
e69ecd6
Compare
pieh
force-pushed
the
feat/support-update-tag-and-revalidate-tag-second-arg
branch
from
e69ecd6 to
e0a4e48
Compare
serhalp
previously approved these changes
Oct 13, 2025
src/run/handlers/tags-handler.cts
Outdated
Comment on lines
35
to
37
| const timestampsOrNulls = await Promise.all(tags.map((tag) => getTagManifest(tag, cacheStore))) | ||
|
|
||
| const timestamps = timestampsOrNulls.filter((timestamp) => timestamp !== null) | ||
| if (timestamps.length === 0) { | ||
| const expirationTimestamps = timestampsOrNulls |
There was a problem hiding this comment.
left over from refactor:
Suggested change
| const timestampsOrNulls = await Promise.all(tags.map((tag) => getTagManifest(tag, cacheStore))) | |
| const timestamps = timestampsOrNulls.filter((timestamp) => timestamp !== null) | |
| if (timestamps.length === 0) { | |
| const expirationTimestamps = timestampsOrNulls | |
| const manifestsOrNulls = await Promise.all(tags.map((tag) => getTagManifest(tag, cacheStore))) | |
| const expirationTimestamps = manifestsOrNulls |
There was a problem hiding this comment.
github didn't allow me to commit suggestion so this was done as part of 37c3e8e#diff-7fe4e66d51e744fc6fd6321c633def547066010bb05aff0ef621b64d84ec5442R35
src/run/handlers/tags-handler.cts
Outdated
| getLogger().withFields({ tags }).debug('doRevalidateTagAndPurgeEdgeCache') | ||
| async function doRevalidateTagAndPurgeEdgeCache( | ||
| tags: string[], | ||
| durations?: { expire?: number }, |
There was a problem hiding this comment.
suggestion:
Suggested change
| durations?: { expire?: number }, | |
| durations?: { expireSeconds?: number }, |
There was a problem hiding this comment.
the durations type is from Next.js - https://github.com/vercel/next.js/blob/fffa2831b61fa74852736eeaad2f17fbdd553bce/packages/next/src/server/lib/incremental-cache/index.ts#L78
I do not need to use the exact type here, but I do need to use original type at least in our CacheHandler and would need to add conversion from Next.js type to our type which doesn't seem worth it?
But for clarity I will add some jsdocs or code comments along the call chain to clarify that expire is in seconds
There was a problem hiding this comment.
added type with some descriptions 8f0a2d4
src/run/handlers/tags-handler.cts
Outdated
| export function markTagsAsStaleAndPurgeEdgeCache(tagOrTags: string | string[]) { | ||
| export function markTagsAsStaleAndPurgeEdgeCache( | ||
| tagOrTags: string | string[], | ||
| durations?: { expire?: number }, |
There was a problem hiding this comment.
suggestion:
Suggested change
| durations?: { expire?: number }, | |
| durations?: { expireSeconds?: number }, |
There was a problem hiding this comment.
same as #3173 (comment)
Comment on lines
+197
to
+198
| if (nextVersionSatisfies('>=16.0.0-alpha.0')) { | ||
| test.describe('app router on-demand revalidation (Next 16 APIs)', () => { |
There was a problem hiding this comment.
since these tests will be relatively slow with all the waiting and they should be independent, maybe we could parallelize them?
Suggested change
| if (nextVersionSatisfies('>=16.0.0-alpha.0')) { | |
| test.describe('app router on-demand revalidation (Next 16 APIs)', () => { | |
| test.describe('app router on-demand revalidation (Next 16 APIs)', () => { | |
| test.describe.configure({ mode: 'parallel' }) |
There was a problem hiding this comment.
github didn't allow me to commit suggestion so I did it in e13e932
Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>
|
a4b1046...feat/support-update-tag-and-revalidate-tag-second-arg for the changes since review (including applied suggestions) |
serhalp
approved these changes
Oct 14, 2025
pieh
deleted the
feat/support-update-tag-and-revalidate-tag-second-arg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support https://nextjs.org/blog/next-16-beta#improved-caching-apis
Note that
updateTagis supported without any changes (I just added test cases for it). The runtime changes are to supportrevaligateTagwith SWR behaviorDocumentation
Tests
Will be added
Relevant links (GitHub issues, etc.) or a picture of cute animal